Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Furnitures/Terrains with ALARMED flag does not Sound the Alarm when Hit #72405

Closed
gettingusedto opened this issue Mar 15, 2024 · 2 comments · Fixed by #77493
Closed

Furnitures/Terrains with ALARMED flag does not Sound the Alarm when Hit #72405

gettingusedto opened this issue Mar 15, 2024 · 2 comments · Fixed by #77493
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Good First Issue This is a good first issue for a new contributor (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@gettingusedto
Copy link
Contributor

Describe the bug

I noticed that vending machine (and potentially the other furnitures/terrains with ALARMED flag) does not actually blares out their alarm when being hit.

Attach save file

N/A

Steps to reproduce

  1. get into a world
  2. find/debug in vending machine
  3. (s)mash it open
  4. no alarm

Expected behavior

it blaring its alarm when being hit.

Screenshots

No response

Versions and configuration

  • OS: Android
    • OS Version: Manufacturer: samsung; Model: SM-A710F; Release: 7.0; Incremental: A710FXXU2CRC2;
  • Game Version: c4dec49 [32-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Slowdown Fungal Growth [no_fungal_growth],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Magiclysm [magiclysm],
    Xedra Evolved [xedra_evolved],
    Mind Over Matter [mindovermatter],
    Bombastic Perks [bombastic_perks],
    GUT's Tweak Compendium [gut_tweaks_compendium],
    GUT's Contents Compendium [gut_contents_compendium],
    GUT's Unhinged Stuff [gut_unhinged_stuff]
    ]

Additional context

Relevant discord convo regarding the issue
https://discord.com/channels/598523535169945603/598529174302490644/1218196735214485606

@gettingusedto gettingusedto added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 15, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 14, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
@Maleclypse Maleclypse reopened this Oct 31, 2024
@Maleclypse Maleclypse added (S2 - Confirmed) Bug that's been confirmed to exist Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility stale Closed for lack of activity, but still valid. labels Oct 31, 2024
@GuardianDll
Copy link
Member

it was removed by accident in 66872, to fix it someone just need to revert this piece of code https://github.com/CleverRaven/Cataclysm-DDA/pull/66872/files#diff-742a716324b97c7b673cb41a50625f5583e55761b4cd8bacaaadf2b2480d0050L3845-L3857

Probably not entire thing, just part of it

    if( has_flag( ter_furn_flag::TFLAG_ALARMED, p ) ) {
        sounds::sound( p, 40, sounds::sound_t::alarm, _( "an alarm go off!" ),
                       false, "environment", "alarm" );
    }

@GuardianDll GuardianDll added Good First Issue This is a good first issue for a new contributor [C++] Changes (can be) made in C++. Previously named `Code` labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Good First Issue This is a good first issue for a new contributor (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants