-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMS 549: dev setup fixes #197
base: master
Are you sure you want to change the base?
Conversation
Remove missing packages from bower install. Add legacy packages with missing packages and reference in gruntfile
6a0911a
to
214a4f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it might do more than just update dev setup. I see changes in legacy_packages
that I'd be hesitant to merge without releasing. What are these changes actually accomplishing?
It looks like this is just us copying code to make sure it's still available based on your PR body?
legacy packages was created because the script build relied on packages that no longer exist in npm or github. Without this change, the script can not be built |
Description
Fixes to enable the project to be built locally.
CMS-549
Changes
Note on Known Test Failures:
When running tests locally (
grunt all or grunt test
) the following errors are observed:ERROR: 'could not load TileJSON at http://a.tiles.mapbox.com/v4/adamjacobbecker.ja7plkah.json?access_token=pk.eyJ1IjoiYWRhbWphY29iYmVja2VyIiwiYSI6Im1SVEQtSm8ifQ.ZgEOSXsv9eLfGQ-9yAmtIg'
This is a known issue with the map_marker field. Referenced mapbox tileset format is no longer supported. See CMS-51
Chrome Headless 126.0.6478.183 (Mac OS 10.15.7) adding and removing rows "before all" hook for "functions properly" FAILED Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
This error occurs frequently but not 100% of the time. Anecdotal observation is that it occurs much less frequently if the map_marker field is removed from test setups. Note that the error message is pointing to a "before all" hook that just creates a new instance of a FormRenderer object (using same test data as in other test cases). But issue may be inside test (where form pages need to be navigated).