Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS 549: dev setup fixes #197

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

barbara-prusiewicz
Copy link

@barbara-prusiewicz barbara-prusiewicz commented Jul 9, 2024

Description
Fixes to enable the project to be built locally.

CMS-549

Changes

  • update tools versions to nodejs 10.22.1 and ruby 2.6.10
  • add legacy-packages folder for packages that were previously available through npm or github but no longer exist. For these packages, the source was extracted from the current formrenderer release(dist/formrenderer.uncompressed.js). Packages are: beforeunload, require_once and iso-country-names
  • remove legacy-packages from bower.json.
  • update gruntfile to get source for legacy packages from legacy-packages folder (vs bower folder)
  • update karma packages and fix karma config accordingly
  • run buildscript to regenerate scripts (in dist folder)

Note on Known Test Failures:
When running tests locally (grunt all or grunt test) the following errors are observed:

ERROR: 'could not load TileJSON at http://a.tiles.mapbox.com/v4/adamjacobbecker.ja7plkah.json?access_token=pk.eyJ1IjoiYWRhbWphY29iYmVja2VyIiwiYSI6Im1SVEQtSm8ifQ.ZgEOSXsv9eLfGQ-9yAmtIg'
This is a known issue with the map_marker field. Referenced mapbox tileset format is no longer supported. See CMS-51

Chrome Headless 126.0.6478.183 (Mac OS 10.15.7) adding and removing rows "before all" hook for "functions properly" FAILED Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
This error occurs frequently but not 100% of the time. Anecdotal observation is that it occurs much less frequently if the map_marker field is removed from test setups. Note that the error message is pointing to a "before all" hook that just creates a new instance of a FormRenderer object (using same test data as in other test cases). But issue may be inside test (where form pages need to be navigated).

Remove missing packages from bower install.
Add legacy packages with missing packages and reference in gruntfile
@barbara-prusiewicz barbara-prusiewicz marked this pull request as draft July 9, 2024 20:46
@samgranieri samgranieri force-pushed the CMS-549_dev-setup-fixes branch from 6a0911a to 214a4f7 Compare July 25, 2024 13:29
@barbara-prusiewicz barbara-prusiewicz marked this pull request as ready for review July 25, 2024 17:40
Copy link

@Serneum Serneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it might do more than just update dev setup. I see changes in legacy_packages that I'd be hesitant to merge without releasing. What are these changes actually accomplishing?

It looks like this is just us copying code to make sure it's still available based on your PR body?

@barbara-prusiewicz
Copy link
Author

barbara-prusiewicz commented Jul 25, 2024

legacy packages was created because the script build relied on packages that no longer exist in npm or github.
So I extracted corresponding code from the previously released script and I put in in the repo in legacy packages

Without this change, the script can not be built

@samgranieri samgranieri self-requested a review August 7, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants