Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBS Studio installed automatically with .json import #2819

Closed
Peppernrino opened this issue Sep 25, 2024 · 3 comments
Closed

OBS Studio installed automatically with .json import #2819

Peppernrino opened this issue Sep 25, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Peppernrino
Copy link

Whenever I choose to import a .json file, OBS Studio ends up getting ticked and I keep installing it by accident.

Steps to reproduce the behavior:

  1. Create .json export excluding OBS Studio
  2. Close Powershell and reopen winutil
  3. Import *.json
  4. Check fo see that OBS Studio is being ticked
@Peppernrino Peppernrino added the bug Something isn't working label Sep 25, 2024
@momcilovicluka
Copy link
Contributor

I conducted a preliminary test and can confirm the presence of the issue. More specifically, during the import process, if Obsidian is imported from JSON, it appears to select both 'Obsidian' and 'OBS' simultaneously. Based on this observation, the root cause seems to reside within the matching logic of import functionality. I will investigate further and make a pull request.

Additionally, when reporting issues of this nature, it would be highly beneficial if you could include the JSON file that was created and used for the import attempt. This would assist in diagnosing the problem more efficiently.

momcilovicluka added a commit to momcilovicluka/winutil that referenced this issue Sep 25, 2024
@momcilovicluka
fix: check for exact match instead of partial
97d9cec 
Split the check boxes into array and in the if statement check for exact
match to avoid collisions like obs being selected when only obsidian is
provided due to partial match

fix: ChrisTitusTech#2819
@momcilovicluka
Copy link
Contributor

momcilovicluka commented Sep 25, 2024 •
edited
Loading

Forgot to sync my main to upstream🙃. Seems to be working fine on the latest main when compiled from source (fixed by #2789 ). The latest hosted version of the tool is not yet compiled from latest main (when getting with windev or otherwise). I suggest closing this as it seems to already be fixed in code, but not hosted as a release yet.

@Peppernrino
Copy link
Author

I can confirm I was installing Obsidian using the tool. :)
I appreciate you looking into this. Glad it's fixed in future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Peppernrino @momcilovicluka