p2p_statement_parser.py: add debug for parsed value #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also write debug output for the value read from the csv input file.
|
Code Climate has analyzed commit 75d59ae and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
Closed
This change breaks current behaviour on how the transaction value output is written to the resulting CSV file. Switching from a hard coded replace '.' to ',' to using locale aware Decimal will break the output generation on some systems where system locale is different from the exptected. For some reason on my side, portfolio performance is not able to handle '.' decimal points.
looks like I was missing the encoding.
Install locale for de_DE.UTF-8 to pass unit tests
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also write debug output for the value read from the csv input file.