Add real daily aggregation, fix small numbers #269
Conversation
Without formatting sometimes scientific formats (e.g. "1,247e-06") are used by default, which cause issues when imported into Portfolio Performance.
| @@ -53,6 +53,26 @@ def config_file(self, value): | |||
| """config file property setter""" | |||
| self._config_file = value | |||
|
|
|||
| def __aggregate_statements_daily(self, formatted_account_entry): | |||
There was a problem hiding this comment.
Schaut gut aus.
Ich denke, dass der parser noch mal refaktoriert werden muss, um die gleichanteile loszuwerden. Eventuell was für später.
Co-authored-by: ChrisRBe <[email protected]>
…o feature_adddailyaggregation
Man vergisst immer was... :) README ist jetzt angepasst. |
|
Fixing the tests might be a bit more complicated, as they are trying to feed strings into the newly introduced integer formatting function... I "fixed" it, but I am not sure you will be happy about it... |
|
Will have a look in a bit once I'm at my desk. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| logging.debug("entry type is {}. new entry date is {}".format(entry_type, entry_date)) | ||
| if entry_date not in self.aggregation_data: | ||
| self.aggregation_data[entry_date] = {} | ||
| if entry_type in self.aggregation_data[entry_date]: |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 1b1f0fc and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 98.9% (0.1% change). View more on Code Climate. |
|
Agh. Ok... seems that we get a little screwed here by ScaCap/action-surefire-report#31 ... will update the workflow to remove the whole step for now. After PR is merged will re-enable it. |
Hi @ChrisRBe,
vielen Dank noch einmal für den tollen Parser. Ich habe eine neue Aggregation hinzugefügt. Damit heisst die alte "daily" aggregation jetzt "transaction", da jede Transaktion 1:1 übernommen wird, und die neue "daily" erzeugt pro Transaktionstyp und Tag einen Eintrag.
Weiterhin habe ich mit einem
str.formatversucht das richtige Format sehr kleiner Zahlen sicherzustellen, da manchmal das wissenschaftliche Format (z.B. "1,247e-06") in die CSV geschrieben wurde, und Portfolio Performance damit ein Problem hat.