Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Multiple Issues for Hipparchus-0.34 (Backport) #21

Open
wants to merge 3 commits into
base: c1/0.34.10
Choose a base branch
from

Conversation

malikankit
Copy link

This is the Hipparchus-0.34 equivalent of this pull request for Hipparchus-0.37 .

  1. Zero out balances for accounts that moved all funds out for all denoms

    • cosmos-sdk will now dump zero balances across all denominations (and not just uatom) for when an account is emptied.
    • Columbus-1, Columbus-2, CosmosHub-1, CosmosHub-2 have a static set of denominations throughout the chain-run.
    • Hence, this version of ChorusOne/cosmos-sdk uses static denominations for the chain-runs Columbus-2 and CosmosHub-2
  2. Cosmos Hub 3 Transaction tags

    • For forward compatibility with the updated submitters (tx.sh) : an additional null column called 'events' has been added to the dump.
  • At Anthem level : we can revert to one of the following methods for deciding between events and tags
    - Check if Chain ID is < 3 : then use jsonTags else use jsonEvents - and parse accordingly
    - Check if jsonEvents column = null : then use jsonTags else use JsonEvents - and parse accordingly.

  • Marking @bonham000 here : as this affects integration with Anthem : assuming this change PR is approved as-is.

  1. Rewards data for days in which a withdrawal took place understate reward
    • The changes ensure that - similar to other file types (delegations, unbond, rewards etc) - the non-bulky commission files also
      a) progress from 'uncheck' folder to 'progress' folder when commitUncheckedFiles() is invoked
      b) and are deleted when deleteUncheckedFiles() is invoked

With the above changes, I have bumped up ChorusOne/cosmos-sdk v0.34.10-12 to v0.34.10-14

TODOs For Ankit

  • Attach link to corresponding pull request for ChorusOne/hipparchus - when ready.

    • Collectively, these two pull requests take a shot at resolving the 3 issues.
  • Post Joe's review and Ankit's follow up commits

    • Point tag to the final HEAD of this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant