Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make use of the Result library #253

Merged
merged 2 commits into from
Feb 20, 2022
Merged

Conversation

Chesire
Copy link
Owner

@Chesire Chesire commented Feb 20, 2022

Description of the change

Use the result library to handle communication from the api back down to the ViewModel.

Closes -

Reason for the change

It's a bit nicer to use the result library, just a cosmetic change more than anything at the moment.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have fixed all new raised warnings

Use the result library to handle communication from the api back down to the ViewModel.
@Chesire Chesire self-assigned this Feb 20, 2022
@commit-lint
Copy link

commit-lint bot commented Feb 20, 2022

Features

  • make use of the Result library (0859369)

Chore

  • add ignore for import ordering rule (1faa092)

Contributors

Chesire

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

Import ordering rule makes the java. and kotlin. imports move to the end, which doesnt work with the
IDE so well.
@Chesire Chesire merged commit d3b5529 into master Feb 20, 2022
@Chesire Chesire deleted the refactor/use-result-lib branch February 20, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant