Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a LiveEvent instead of Livedata for api result #151

Merged
merged 1 commit into from
May 29, 2021

Conversation

Chesire
Copy link
Owner

@Chesire Chesire commented May 29, 2021

Description of the change

Use LiveEvent so it only occurs once, this stops the LiveData firing a second time if navigating
between the settings and pusher view.

@Chesire Chesire self-assigned this May 29, 2021
@commit-lint
Copy link

commit-lint bot commented May 29, 2021

Bug Fixes

  • use a LiveEvent instead of Livedata for api result (e90c2cc)

Contributors

Chesire

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

Use LiveEvent so it only occurs once, this stops the livedata firing a second time if navigating
between the settings and pusher view.
@Chesire Chesire force-pushed the fix/livedata-firing-on-navigation branch from c070433 to e90c2cc Compare May 29, 2021 19:29
@Chesire Chesire merged commit 6a29e7d into master May 29, 2021
@Chesire Chesire deleted the fix/livedata-firing-on-navigation branch May 29, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant