Adding timeout capability to api_call #27
Merged
+25
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on a project using this api, we recently faced the need to add a timeout feature to
api_call
. This allowed us to cancel some calls that wouldn't end (for reason not related to this api). This is working great for us so far, and we propose to merge it upstream.The change made is simple, when calling
api_call
, an optional (no backward compatibility issue) field called timeout can be filled. Any positive integer will be translated as a timeout (in seconds) before which the call has to finish. Otherwise the request will be terminated and aTimeoutException
(inheriting fromApiException
) will be raised.