Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client(consensus/grandpa): implement finality proof logic #3589

Merged
merged 18 commits into from
Dec 13, 2023
Merged

client(consensus/grandpa): implement finality proof logic #3589

merged 18 commits into from
Dec 13, 2023

Conversation

jimjbrettj
Copy link
Contributor

Changes

  • Implement and test logic for creating and verifying grandpa finality proofs

Tests

go test ./client/consensus/grandpa

Issues

#3582

Primary Reviewer

@timwu20

EclesioMeloJunior
EclesioMeloJunior requested changes Nov 20, 2023
View reviewed changes
client/consensus/grandpa/blockOrigin.go Outdated Show resolved Hide resolved
client/consensus/grandpa/blockOrigin.go Outdated Show resolved Hide resolved
timwu20
timwu20 requested changes Nov 21, 2023
View reviewed changes
client/consensus/grandpa/finality_proof.go Outdated Show resolved Hide resolved
client/consensus/grandpa/finality_proof.go Show resolved Hide resolved
client/consensus/grandpa/finality_proof.go Outdated Show resolved Hide resolved
client/consensus/grandpa/finality_proof.go Outdated Show resolved Hide resolved
client/consensus/grandpa/finality_proof.go Outdated Show resolved Hide resolved
client/consensus/grandpa/interfaces.go Outdated Show resolved Hide resolved
@jimjbrettj jimjbrettj requested a review from timwu20 November 22, 2023 21:06
EclesioMeloJunior
EclesioMeloJunior reviewed Nov 29, 2023
View reviewed changes
client/consensus/grandpa/authorities.go Outdated Show resolved Hide resolved
client/consensus/grandpa/authorities.go Outdated Show resolved Hide resolved
client/consensus/grandpa/authorities.go Outdated Show resolved Hide resolved
EclesioMeloJunior
EclesioMeloJunior requested changes Dec 4, 2023
View reviewed changes
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I noticed that the function checkMessageSignature can receive a signature that can be []byte or string, but why not set the signature type to be []byte always, and then let the caller to transform the string to []bytes?

client/consensus/grandpa/authorities.go Show resolved Hide resolved
timwu20
timwu20 requested changes Dec 7, 2023
View reviewed changes
client/consensus/grandpa/authorities.go Outdated Show resolved Hide resolved
client/consensus/grandpa/aux_schema.go Outdated Show resolved Hide resolved
client/consensus/grandpa/finality_proof.go Show resolved Hide resolved
client/consensus/grandpa/finality_proof.go Outdated Show resolved Hide resolved
client/consensus/grandpa/finality_proof.go Outdated Show resolved Hide resolved
client/consensus/grandpa/finality_proof_test.go Outdated Show resolved Hide resolved
client/consensus/grandpa/finality_proof_test.go Show resolved Hide resolved
client/consensus/grandpa/finality_proof_test.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Outdated Show resolved Hide resolved
client/consensus/grandpa/justification.go Show resolved Hide resolved
@jimjbrettj jimjbrettj requested a review from timwu20 December 12, 2023 23:35
@jimjbrettj jimjbrettj merged commit 8f28c20 into feat/grandpa Dec 13, 2023
45 checks passed
@jimjbrettj jimjbrettj deleted the jimmy/finalityProof branch December 13, 2023 18:05
@jimjbrettj jimjbrettj mentioned this pull request Dec 13, 2023
Closed
timwu20 added a commit that referenced this pull request Apr 18, 2024
@jimjbrettj @timwu20
client(consensus/grandpa): implement finality proof logic (#3589)
21f8972 
Co-authored-by: Timothy Wu <[email protected]>
timwu20 added a commit that referenced this pull request Apr 19, 2024
@jimjbrettj @timwu20
client(consensus/grandpa): implement finality proof logic (#3589)
687ae0e 
Co-authored-by: Timothy Wu <[email protected]>
timwu20 added a commit that referenced this pull request Apr 19, 2024
@jimjbrettj @timwu20
client(consensus/grandpa): implement finality proof logic (#3589)
ea9557e 
Co-authored-by: Timothy Wu <[email protected]>
timwu20 added a commit that referenced this pull request Apr 19, 2024
@jimjbrettj @timwu20
client(consensus/grandpa): implement finality proof logic (#3589)
fa3fd23 
Co-authored-by: Timothy Wu <[email protected]>
timwu20 added a commit that referenced this pull request Apr 19, 2024
@jimjbrettj @timwu20
client(consensus/grandpa): implement finality proof logic (#3589)
e85e13e 
Co-authored-by: Timothy Wu <[email protected]>
timwu20 added a commit that referenced this pull request Oct 11, 2024
@jimjbrettj @timwu20
client(consensus/grandpa): implement finality proof logic (#3589)
6da2666 
Co-authored-by: Timothy Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@timwu20 timwu20 timwu20 approved these changes

@edwardmack edwardmack Awaiting requested review from edwardmack

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

@dimartiro dimartiro Awaiting requested review from dimartiro

@kanishkatn kanishkatn Awaiting requested review from kanishkatn

@axaysagathiya axaysagathiya Awaiting requested review from axaysagathiya

Assignees

@timwu20 timwu20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jimjbrettj @timwu20 @kanishkatn @EclesioMeloJunior @axaysagathiya