Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib/babe): TestCalculateThreshold failing locally #3178

Closed
wants to merge 3 commits into from
Closed

fix(lib/babe): TestCalculateThreshold failing locally #3178

wants to merge 3 commits into from

Conversation

EclesioMeloJunior
Copy link
Member

Changes

  • TestCalculateThreshold failed locally due to a difference of 1 byte

Tests

go test -timeout 10m -run ^TestCalculateThreshold$ github.com/ChainSafe/gossamer/lib/babe --tags=integration -v

Issues

N/A

Primary Reviewer

@kanishkatn @jimjbrettj @dimartiro

@EclesioMeloJunior
fix(lib/babe): TestCalculateThreshold failing locally
ce0c97a 
`TestCalculateThreshold` failed locally due a difference of 1 byte
@EclesioMeloJunior EclesioMeloJunior marked this pull request as ready for review March 27, 2023 15:09
dimartiro
dimartiro approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@dimartiro dimartiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed in my machine now! thanks!! Did you test it in a non ARM chip?

@kanishkatn
Copy link
Contributor

It's failing in CI https://github.com/ChainSafe/gossamer/actions/runs/4533539522/jobs/7986488571?pr=3178#step:10:44

@EclesioMeloJunior EclesioMeloJunior marked this pull request as draft March 27, 2023 17:50
@jimjbrettj
Copy link
Contributor

This fails for me with the following output:

image

@jimjbrettj
Copy link
Contributor

I and the CI both run on x86_64, so it seems there must be some difference in arm vs x86_64 causing this to fail

@EclesioMeloJunior
Copy link
Member Author

Jimmy's PR #3168 solves the problem by removing the C dependencies we have with the wasmer runtime so now Apple Silicon users can go back to arm64 using: go env -w GOARCH=arm64 and then the test will pass as a charm!! Nice work @jimjbrettj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimartiro dimartiro dimartiro approved these changes

@noot noot Awaiting requested review from noot

@edwardmack edwardmack Awaiting requested review from edwardmack

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

@qdm12 qdm12 Awaiting requested review from qdm12

@P1sar P1sar Awaiting requested review from P1sar P1sar will be requested when the pull request is marked ready for review P1sar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EclesioMeloJunior @kanishkatn @jimjbrettj @dimartiro