Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lib/babe): fix test verification manager verfify block multiple epochs #3120

Merged
merged 24 commits into from
Mar 1, 2023
Merged

chore(lib/babe): fix test verification manager verfify block multiple epochs #3120

merged 24 commits into from
Mar 1, 2023

Conversation

jimjbrettj
Copy link
Contributor

Changes

  • Rewrote the test for testing block verification over multiple epochs
  • Inject babe config to test helper and use westend babe config for testing

Tests

go test ./lib/babe --tags=integration

Issues

#3060

Primary Reviewer

@timwu20

@jimjbrettj jimjbrettj force-pushed the jimmy/fixTestVerificationManager_VerfifyBlock_multipleEpochs branch 2 times, most recently from 32a7c81 to a8569f9 Compare February 16, 2023 21:29
@jimjbrettj jimjbrettj marked this pull request as ready for review February 16, 2023 21:29
qdm12
qdm12 approved these changes Feb 20, 2023
View reviewed changes
lib/babe/helpers_test.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
EclesioMeloJunior
EclesioMeloJunior approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment

lib/babe/helpers_test.go Outdated Show resolved Hide resolved
@jimjbrettj jimjbrettj force-pushed the jimmy/fixTestVerificationManager_VerfifyBlock_multipleEpochs branch 4 times, most recently from 612ad7e to 3c1d98a Compare March 1, 2023 14:59
@jimjbrettj jimjbrettj force-pushed the jimmy/fixTestVerificationManager_VerfifyBlock_multipleEpochs branch from 3c1d98a to cc4446a Compare March 1, 2023 17:17
@jimjbrettj jimjbrettj merged commit fe4e1a9 into development Mar 1, 2023
@jimjbrettj jimjbrettj deleted the jimmy/fixTestVerificationManager_VerfifyBlock_multipleEpochs branch March 1, 2023 18:55
EclesioMeloJunior pushed a commit that referenced this pull request Mar 10, 2023
@jimjbrettj @EclesioMeloJunior
chore(lib/babe): fix test verification manager verfify block multiple…
082e177 
… epochs (#3120)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qdm12 qdm12 qdm12 approved these changes

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@noot noot Awaiting requested review from noot

@edwardmack edwardmack Awaiting requested review from edwardmack

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimjbrettj @qdm12 @EclesioMeloJunior