Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests/rpc): flaky test TestChainSubscriptionRPC/chain_subscribeNewHeads #3092

Merged
merged 5 commits into from
Feb 2, 2023
Merged

fix(tests/rpc): flaky test TestChainSubscriptionRPC/chain_subscribeNewHeads #3092

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c266879
fix: ensure the numbers are greater or equal at `TestChainSubscriptio…
EclesioMeloJunior Feb 2, 2023
37ccfe8
Merge branch 'development' into eclesio/fix-subscribe-new-heads-test
EclesioMeloJunior Feb 2, 2023
1f1ea7c
Merge branch 'development' into eclesio/fix-subscribe-new-heads-test
EclesioMeloJunior Feb 2, 2023
47f00be
Merge branch 'development' into eclesio/fix-subscribe-new-heads-test
EclesioMeloJunior Feb 2, 2023
7da6908
Merge branch 'development' into eclesio/fix-subscribe-new-heads-test
EclesioMeloJunior Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/rpc/rpc_03-chain_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func TestChainSubscriptionRPC(t *testing.T) { //nolint:tparallel
result := getResultMapFromParams(t, params)

number := getResultNumber(t, result)
assert.Equal(t, uint(i+1), number)
assert.GreaterOrEqual(t, uint(i+1), number)

assertResult32BHex(t, result, "parentHash")
assertResult32BHex(t, result, "stateRoot")
Expand Down