chore(cmd/gossamer): Request chain spec as an argument in import-runtime command
#3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EclesioMeloJunior
requested review from
noot,
edwardmack,
timwu20,
jimjbrettj,
kishansagathiya and
qdm12
as code owners
…ub.com:ChainSafe/gossamer into eclesio/remove-import-runtime-gssmr-dependency
jimjbrettj
reviewed
Jan 24, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #3067 +/- ##
===============================================
+ Coverage 51.65% 51.94% +0.29%
===============================================
Files 220 220
Lines 28086 28081 -5
===============================================
+ Hits 14507 14587 +80
+ Misses 12289 12199 -90
- Partials 1290 1295 +5 |
…ub.com:ChainSafe/gossamer into eclesio/remove-import-runtime-gssmr-dependency
qdm12
approved these changes
Jan 27, 2023
…ub.com:ChainSafe/gossamer into eclesio/remove-import-runtime-gssmr-dependency
EclesioMeloJunior
deleted the
eclesio/remove-import-runtime-gssmr-dependency
branch
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
import-runtimeargument was tightly coupled with thegssmrgenesis spec file so in order to remove this dependency I've introduced the genesis spec file as an argument to theimport-runtimecommandTests
go test -tags integration github.com/ChainSafe/gossamer/cmd/gossamerIssues
GetGssmrGenesisPathfromcreateGenesisWithRuntime#3013Primary Reviewer
@jimjbrettj