Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lib/babe): fix TestBuildAndApplyExtrinsic for westend #3037

Merged
merged 26 commits into from
Jan 26, 2023
Merged

chore(lib/babe): fix TestBuildAndApplyExtrinsic for westend #3037

merged 26 commits into from
Jan 26, 2023

Conversation

jimjbrettj
Copy link
Contributor

@jimjbrettj jimjbrettj commented Jan 12, 2023 •
edited
Loading

Changes

  • Fix all babe integration tests to use Westend
  • Pass in genesis, genesisTrie, and GenesisHeader to service builder in tests to allow for more flexible testing
  • Create a helper function to get Westend genesis
  • Create issue to address skipped test in this PR that require a more in-depth refactor or rewrite

Tests

go test --tags=integration ./lib/babe

Issues

#3019 #2704

Primary Reviewer

@EclesioMeloJunior

@jimjbrettj jimjbrettj force-pushed the jimmy/fixBabeTestsWestend branch from b65800b to 1b29ffc Compare January 13, 2023 18:13
@codecov
Copy link

codecov bot commented Jan 13, 2023 •
edited
Loading

Codecov Report

Merging #3037 (cb623e6) into development (d7e1177) will decrease coverage by 0.02%.
The diff coverage is 46.15%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           development    #3037      +/-   ##
===============================================
- Coverage        51.62%   51.61%   -0.02%     
===============================================
  Files              220      220              
  Lines            28089    28087       -2     
===============================================
- Hits             14500    14496       -4     
- Misses           12298    12300       +2     
  Partials          1291     1291

EclesioMeloJunior
EclesioMeloJunior requested changes Jan 19, 2023
View reviewed changes
lib/babe/build.go Outdated Show resolved Hide resolved
lib/babe/build_integration_test.go Outdated Show resolved Hide resolved
@jimjbrettj jimjbrettj force-pushed the jimmy/fixBabeTestsWestend branch from 1aea121 to df8b2e2 Compare January 19, 2023 20:24
kishansagathiya
kishansagathiya reviewed Jan 20, 2023
View reviewed changes
lib/babe/babe_integration_test.go Outdated Show resolved Hide resolved
lib/babe/babe_integration_test.go Show resolved Hide resolved
lib/babe/babe_integration_test.go Outdated Show resolved Hide resolved
lib/babe/babe_integration_test.go Outdated Show resolved Hide resolved
lib/babe/build.go Show resolved Hide resolved
lib/babe/build.go Show resolved Hide resolved
lib/babe/build_integration_test.go Outdated Show resolved Hide resolved
lib/babe/build_integration_test.go Outdated Show resolved Hide resolved
timwu20
timwu20 reviewed Jan 21, 2023
View reviewed changes
lib/babe/babe_integration_test.go Show resolved Hide resolved
lib/babe/build_integration_test.go Outdated Show resolved Hide resolved
lib/babe/build_integration_test.go Outdated Show resolved Hide resolved
lib/babe/build_integration_test.go Outdated Show resolved Hide resolved
lib/babe/build_integration_test.go Show resolved Hide resolved
lib/babe/build_integration_test.go Outdated Show resolved Hide resolved
lib/babe/build_integration_test.go Outdated Show resolved Hide resolved
@jimjbrettj jimjbrettj force-pushed the jimmy/fixBabeTestsWestend branch from df8b2e2 to 0e0b991 Compare January 23, 2023 19:48
@jimjbrettj jimjbrettj mentioned this pull request Jan 23, 2023
Closed
7 tasks
@jimjbrettj jimjbrettj force-pushed the jimmy/fixBabeTestsWestend branch from e91eb31 to 1e247a3 Compare January 24, 2023 20:09
EclesioMeloJunior
EclesioMeloJunior approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀 🚀

kishansagathiya
kishansagathiya previously requested changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@kishansagathiya kishansagathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3037 (comment)

qdm12
qdm12 reviewed Jan 25, 2023
View reviewed changes
lib/runtime/test_helpers.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
lib/babe/helpers_test.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
lib/babe/verify_integration_test.go Show resolved Hide resolved
lib/babe/verify_integration_test.go Outdated Show resolved Hide resolved
@jimjbrettj jimjbrettj force-pushed the jimmy/fixBabeTestsWestend branch from f7b4939 to aec80fa Compare January 25, 2023 18:58
jimjbrettj and others added 20 commits January 26, 2023 14:34
@jimjbrettj jimjbrettj force-pushed the jimmy/fixBabeTestsWestend branch from f78c68c to 634b2a1 Compare January 26, 2023 21:34
@jimjbrettj jimjbrettj merged commit 5efd712 into development Jan 26, 2023
@jimjbrettj jimjbrettj deleted the jimmy/fixBabeTestsWestend branch January 26, 2023 23:25
This was referenced Jan 27, 2023
Closed
Closed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qdm12 qdm12 qdm12 approved these changes

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@kishansagathiya kishansagathiya kishansagathiya left review comments

@noot noot Awaiting requested review from noot

@edwardmack edwardmack Awaiting requested review from edwardmack

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jimjbrettj @timwu20 @kishansagathiya @qdm12 @EclesioMeloJunior