Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: confirm block import notifier is closed properly #1736
fix: confirm block import notifier is closed properly #1736
Changes from all commits
0a59cb3
a8cffd8
30338f7
6ed9d63
0bc1f97
2ae9572
0f95d68
2b16fa6
7f10eec
5f1c2a6
2b512b2
e3bd220
fd6d7cc
125b68a
ee0fc7b
6ca1a8b
d3eaa06
41bb429
f0f76f1
0164305
b7f658f
74f094d
8a49ae7
35180df
faf2664
db397cd
4b7d341
d5d0d57
f72e744
a478d5c
d5754d9
8b8066c
1acfba7
ce706cc
515391d
8ad895c
6b46fcd
6bfb77d
48f6db0
8b30110
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be good to update the
finalised
notifiers with the new architecture as well, as it has the same problem. can open another issue or do this in this PR, up to youThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll update once the architecture is set.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.