Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): release v0.4.0 #1513

Merged
merged 21 commits into from
Apr 13, 2021
Merged

chore(release): release v0.4.0 #1513

merged 21 commits into from
Apr 13, 2021

Conversation

arijitAD
Copy link
Contributor

@arijitAD arijitAD commented Apr 8, 2021

Changes

  • Creating a new release

Tests


Issues

noot and others added 17 commits March 23, 2021 10:00
…nd human-readable genesis to be passed to it (#1500)
* Beginning new docs

* Theming set up

* General layouts n links sorted

* Cleaned up

* Updated Commandline

* Cleaned a bit

* Minor cleaning

* Removed todo

* Config page

* Connect to Polkadotjs

* Fixed dev resources

* New categories sorted

* Updated permalink

* Corrected contributor doc

* Removed unused partials

* Tidying

* Removed offical nodes page

* Amended with feed back

* Resolved a majority of feedback

* Ammeded workflows

* Feedback

* Added diagram

* Recent feedback

* Test package content

* Removed comment

* Debugging page

* Block production expansion

* Typos

* Host spec link

Co-authored-by: noot <[email protected]>
* generate random name if --name flag not set

* update tests with name flag to handle random names

* update tests that reference name cfg
* implement telemetry connection server

* add telemetry for import block

* setup telemetry to use node name from Global config

* init telemetry connections based on genesis.json values

* fix error message formatting

* add tests for telemetry

* implement no-telemetry cli flag

* fix typos

* cleanup error check

* create TelemetryEndpoint struct

* created connection data struct to hold connection data

* make TelemetryEndpoints a pointer reference

* add tests for interfaceToTelemetryEndpoint

* update test to fix random name
@arijitAD arijitAD requested review from edwardmack and noot as code owners April 8, 2021 17:01
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #1513 (558b9b3) into main (b8c4dd7) will increase coverage by 0.41%.
The diff coverage is 66.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
+ Coverage   58.62%   59.04%   +0.41%     
==========================================
  Files         151      155       +4     
  Lines       15057    15293     +236     
==========================================
+ Hits         8827     9029     +202     
- Misses       4690     4705      +15     
- Partials     1540     1559      +19     
Flag Coverage Δ
unit-tests 59.04% <66.42%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/gossamer/account.go 47.36% <ø> (ø)
cmd/gossamer/flags.go 57.14% <ø> (ø)
cmd/gossamer/utils.go 69.09% <0.00%> (ø)
dot/network/config.go 67.27% <ø> (ø)
dot/rpc/helpers.go 36.36% <0.00%> (ø)
dot/state/service.go 45.94% <0.00%> (-0.25%) ⬇️
dot/system/service.go 90.00% <ø> (ø)
dot/types/header.go 59.18% <ø> (ø)
dot/utils.go 80.18% <ø> (ø)
lib/babe/babe.go 46.00% <ø> (-0.26%) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c4dd7...558b9b3. Read the comment docs.

@noot
Copy link
Contributor

noot commented Apr 8, 2021

@arijitAD could you name this something like "release v0.4.0" or "0.3.3" (whatever the version will be, I guess "0.4.0" since we have new features)?

edwardmack
edwardmack previously approved these changes Apr 9, 2021
* Update package.json.

* Disable package publish to npm.

* Add support to skip a release.
edwardmack
edwardmack previously approved these changes Apr 13, 2021
name: Release
on:
push:
branches: [main, development]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indicates that when we merge to either main or development the release workflow is triggered. Don't we just want this to be main ? @arijitAD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job will be triggered but it won't trigger a release. I will fix this after this release is done.

@noot noot changed the title chore(release): Creating a new release. chore(release): release v0.4.0 Apr 13, 2021
@arijitAD arijitAD requested a review from dutterbutter April 13, 2021 15:56
@arijitAD arijitAD merged commit d53e245 into main Apr 13, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants