-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: dot/rpc: move websocket messages and listeners subscription package #1459
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1459 +/- ##
===============================================
+ Coverage 58.14% 58.69% +0.54%
===============================================
Files 152 151 -1
Lines 15327 15055 -272
===============================================
- Hits 8912 8836 -76
+ Misses 4860 4682 -178
+ Partials 1555 1537 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it will be better if we had a package subscription
which had two files: listener.go
and messages.go
Also, I had a couple of related questions and comments which I posted on this PR.
#1460
Edward Mack: refactor: dot/rpc: move websocket messages and listeners subscription package (#1459)
Changes
Tests
Checklist
Issues