Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: dot/rpc: move websocket messages and listeners subscription package #1459

Merged
merged 10 commits into from
Mar 19, 2021

Conversation

edwardmack
Copy link
Contributor

@edwardmack edwardmack commented Mar 12, 2021

Changes

  • Moved functions and structs related to messages into message.go in subscription package.
  • Moved functions and structs related to notification listening into listeners.go in subscription package.
  • Moved websocket.go into package subscription.

Tests

go test ./dot/rpc/... -short 

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

dot/rpc/websocketListeners.go Outdated Show resolved Hide resolved
dot/rpc/websocketMessages.go Outdated Show resolved Hide resolved
@edwardmack edwardmack requested a review from noot March 15, 2021 17:33
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #1459 (53e41a5) into development (aad1df3) will increase coverage by 0.54%.
The diff coverage is 76.31%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1459      +/-   ##
===============================================
+ Coverage        58.14%   58.69%   +0.54%     
===============================================
  Files              152      151       -1     
  Lines            15327    15055     -272     
===============================================
- Hits              8912     8836      -76     
+ Misses            4860     4682     -178     
+ Partials          1555     1537      -18     
Flag Coverage Δ
unit-tests 58.69% <76.31%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dot/rpc/http.go 71.96% <76.31%> (+12.75%) ⬆️
lib/grandpa/grandpa.go 64.27% <0.00%> (-0.76%) ⬇️
dot/network/sync.go 63.70% <0.00%> (+0.46%) ⬆️
dot/network/notifications.go 63.46% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad1df3...53e41a5. Read the comment docs.

Copy link
Contributor

@arijitAD arijitAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel it will be better if we had a package subscription which had two files: listener.go and messages.go
Also, I had a couple of related questions and comments which I posted on this PR.
#1460

@edwardmack edwardmack changed the title refactor: dot/rpc: move websocket messages and listeners into separate files refactor: dot/rpc: move websocket messages and listeners subscription package Mar 18, 2021
@noot noot merged commit dad3f3d into development Mar 19, 2021
@noot noot deleted the ed/moveWebsocketListeners branch March 19, 2021 15:40
github-actions bot pushed a commit that referenced this pull request Mar 19, 2021
Edward Mack: refactor: dot/rpc: move websocket messages and listeners subscription package (#1459)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants