Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6620] [ENG-6732] Added tests for versioned DOI and CrossRef metadata + Update Preprint Factory #10840

Conversation

bodintsov
Copy link

@bodintsov bodintsov commented Dec 11, 2024

Purpose

Add test for versioned DOI and crossref_metadata

Changes

Add test for versioned DOI and crossref_metadata

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-6620

Part of https://openscience.atlassian.net/browse/ENG-6732

@bodintsov bodintsov marked this pull request as ready for review December 11, 2024 13:51
@cslzchen cslzchen changed the title added tests for versioned DOI and crossref metadata [ENG-6620] Added tests for versioned DOI and CrossRef metadata Dec 11, 2024
osf_tests/factories.py Outdated Show resolved Hide resolved
osf_tests/factories.py Outdated Show resolved Hide resolved
tests/identifiers/test_crossref.py Outdated Show resolved Hide resolved
tests/identifiers/test_crossref.py Outdated Show resolved Hide resolved
tests/identifiers/test_crossref.py Outdated Show resolved Hide resolved
@cslzchen
Copy link
Collaborator

Update: take a look at related failures in #10844, which may overlap with your changes in this file tests/identifiers/test_crossref.py.

osf_tests/factories.py Outdated Show resolved Hide resolved
@cslzchen cslzchen changed the title [ENG-6620] Added tests for versioned DOI and CrossRef metadata [ENG-6620] [ENG-6732] Added tests for versioned DOI and CrossRef metadata Dec 13, 2024
@cslzchen cslzchen changed the title [ENG-6620] [ENG-6732] Added tests for versioned DOI and CrossRef metadata [ENG-6620] [ENG-6732] Added tests for versioned DOI and CrossRef metadata + Update Preprint Factory Dec 13, 2024
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All relevant tests have passed.

tests/identifiers/test_crossref.py .............

@cslzchen cslzchen merged commit 93997e5 into CenterForOpenScience:feature/preprints-doi-versioning Dec 14, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants