Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars not clearing last game when loading a new game #6685

Closed
bm3719 opened this issue Dec 14, 2024 · 1 comment · Fixed by #6687
Closed

Stars not clearing last game when loading a new game #6685

bm3719 opened this issue Dec 14, 2024 · 1 comment · Fixed by #6687
Assignees
Labels
Adventure For the Adventure Module

Comments

@bm3719
Copy link

bm3719 commented Dec 14, 2024

Describe the bug
If stars are used to mark locations in game (by hitting B when in them), then a New Game+ is started, the stars remain on the map.

To Reproduce
Steps to reproduce the behavior:

  1. Enter a dungeon and hit B to mark the dungeon with a star.
  2. Save the game.
  3. Start a new game and enter the overland.
  4. Hit M to open the map. The previously placed star will still be present.

This probably works the same for starring towns too.

Expected behavior
Clear all stars when New Game+ is started.

Screenshots
image

Here you can see I've starred 3 dungeons in my previous game and 2 in my current one. The 3 from the previous game are still present, marking nothing and now can't be removed.

Desktop (please complete the following information):

  • OS: Debian Linux
  • Version 2.0.00-SNAPSHOT-11.21
@Hanmac Hanmac added the Adventure For the Adventure Module label Dec 14, 2024
@bm3719
Copy link
Author

bm3719 commented Dec 14, 2024

Additional testing suggests stars persist during the game session. If you go through the above, then restart the game, the erroneous stars for that save will no longer be present. However, if you have a few saves with stars in various locations, you can recreate the problem by loading various games.

So, it's not that New Game+ doesn't clear the stars, it's more that they stick around between games without a restart.

@tehdiplomat tehdiplomat changed the title Stars marking locations persist after New Game+ Stars not clearing last game when loading a new game Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adventure For the Adventure Module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants