Allow to configure timeout duration by a provider #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I really enjoy the work done on postman, it's beautiful and simple. I needed to change the duration of the timeout, so I propose to add a provider which can be use during the config phase (so it can be extended in the future for others parameters). If you agree with this, can you do the merge ? Thank you
| @@ -9,8 +9,20 @@ | |||
| if($rootElement[0].tagName !== 'HTML') $rootElement.append($elem); | |||
| else angular.element(document.body).append($elem); | |||
| }]) | |||
|
|
|||
| .directive('postmanParcels', ['$timeout', function ($timeout) { | |||
| .provider('postmanSettings', function() { | |||
There was a problem hiding this comment.
Does this make it postmanSettingsProvider in the config? Can you not name it the same as the factory and then just access it via name + Provider?
There was a problem hiding this comment.
I tried to name it "postman" but postmanProvider is undefined when I use it in the config. I guess it's a conflict with the factory.
|
I like it 👍 Will you add some docs/usage in the README? |
|
Ok i'm adding some lines to the Readme. |
|
Done for the README |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I really enjoy the work done on postman, it's beautiful and simple.
I needed to change the duration of the timeout, so I propose to add a provider which can be use during the config phase (so it can be extended in the future for others parameters).
Example of use :
If you agree with this, can you do the merge ?
Thank you