Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging as publishing blog post #22

Merged
merged 16 commits into from
Sep 8, 2023
Merged

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Sep 5, 2023

This PR adds content surrounding a new blog post titled: "Tip of the Week: Python Packaging as Publishing". My hope here is to cover the "justification" and "preparation" portions of packaging, covering "distribution" (i.e. PyPI, etc) in a separate post in the future.

Thanks in advance for any feedback and thoughts you may have on this!

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for set-website ready!

Name Link
🔨 Latest commit a201f00
🔍 Latest deploy log https://app.netlify.com/sites/set-website/deploys/64fb4df9b4e1df00087a9d07
😎 Deploy Preview https://deploy-preview-22--set-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://CU-DBMI.github.io/set-website/preview/pr-22/
on branch gh-pages at 2023-09-08 16:39 UTC

@vincerubinetti
Copy link

vincerubinetti commented Sep 6, 2023

I'll review in full tomorrow but you shouldn't need the {:.left} and {:.center}s. The figure component and caption should be centered by default, and it looks like the markdown parser can't put the center class on a component (HTML snippet) and so just puts it on the following paragraph. So, your following paragraphs get both center and left, and the center class happens to come after the left class (in util.css) so it takes priority and left doesn't work.

The images and everything look great.

Copy link

@vincerubinetti vincerubinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely written and nice images. LGTM.

Copy link

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I agree with Vince; the images make this an easy and engaging read.

@d33bs
Copy link
Member Author

d33bs commented Sep 8, 2023

Thank you @vincerubinetti and @falquaddoomi for the reviews! Merging this in.

@d33bs d33bs merged commit 5e279c0 into CU-DBMI:main Sep 8, 2023
2 checks passed
@d33bs d33bs deleted the packaging-as-publishing branch September 8, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants