This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
CSCFAIRADM-337: [ADD] Update domain references #631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MattiasLevlin
commented
Sep 8, 2020
- These mostly concern test data, but should be updated still
- These mostly concern test data, but should be updated still
katrite
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely!
katrite
pushed a commit
that referenced
this pull request
Oct 5, 2020
* CSCFAIRMETA-647: [FIX] bug with almost simultaneous requests - LightFileserializer made modifications to class variable so when two requests came almost at the same time the latter was using modified version of the variable. Fixed with deepcopy - Changed app to use local Elasticsearch with tests since it is now working * CSCFAIRMETA-710: [FIX] _mapping endpoint and ES in testcases - Correctly call elasticsearch when request comes to _mapping endpoint - Tests can be run against local elasticsearch which reduces the population time - Follow naming convention in refdata loader with non-internal functions * CSCFAIRMETA-710: [FIX] remove unnecessary variable * CSCFAIRADM-337: [ADD] Update domain references (#631) - These mostly concern test data, but should be updated still * CSCFAIRMETA-704 [FIX] merge-draft-does-not-save-changes - In merge_draft take preservation_state from draft cr * CSCFAIRMETA-704-merge-draft-does-not-save-changes - Change metax-demo to metax.demo * CSCFAIRMETA-716: [FIX] create-draft-internal-error-when-draft-already-exists - Add a check for next_draft * CSCFAIRMETA-712-Issues-with-emails -Add migration to change email and organization name * CSCFAIRMETA-712-Issues-with-emails - Add check whether metadata_owner_org or metadata_provider_org exists * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Add ?keys=datasets|files and ?keysonly=bool - Remove parameter ?detailed as it is the same as ?keys=files * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Add test for parameter ?keysonly * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Add support for leaving argument ?detailed * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset Add ?keysonly return input list except standalone files or datasets without files * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Refactor sql's - Fix parameters 'request' and 'preferred_identifier' Co-authored-by: Tommi Pulli <[email protected]> Co-authored-by: Tommi Pulli <[email protected]> Co-authored-by: Mattias Levlin <[email protected]>
katrite
pushed a commit
that referenced
this pull request
Oct 5, 2020
* CSCFAIRMETA-647: [FIX] bug with almost simultaneous requests - LightFileserializer made modifications to class variable so when two requests came almost at the same time the latter was using modified version of the variable. Fixed with deepcopy - Changed app to use local Elasticsearch with tests since it is now working * CSCFAIRMETA-710: [FIX] _mapping endpoint and ES in testcases - Correctly call elasticsearch when request comes to _mapping endpoint - Tests can be run against local elasticsearch which reduces the population time - Follow naming convention in refdata loader with non-internal functions * CSCFAIRMETA-710: [FIX] remove unnecessary variable * CSCFAIRADM-337: [ADD] Update domain references (#631) - These mostly concern test data, but should be updated still * CSCFAIRMETA-704 [FIX] merge-draft-does-not-save-changes - In merge_draft take preservation_state from draft cr * CSCFAIRMETA-704-merge-draft-does-not-save-changes - Change metax-demo to metax.demo * CSCFAIRMETA-716: [FIX] create-draft-internal-error-when-draft-already-exists - Add a check for next_draft * CSCFAIRMETA-712-Issues-with-emails -Add migration to change email and organization name * CSCFAIRMETA-712-Issues-with-emails - Add check whether metadata_owner_org or metadata_provider_org exists * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Add ?keys=datasets|files and ?keysonly=bool - Remove parameter ?detailed as it is the same as ?keys=files * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Add test for parameter ?keysonly * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Add support for leaving argument ?detailed * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset Add ?keysonly return input list except standalone files or datasets without files * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Refactor sql's - Fix parameters 'request' and 'preferred_identifier' Co-authored-by: Tommi Pulli <[email protected]> Co-authored-by: Tommi Pulli <[email protected]> Co-authored-by: Mattias Levlin <[email protected]> Co-authored-by: Tommi Pulli <[email protected]> Co-authored-by: Tommi Pulli <[email protected]> Co-authored-by: Mattias Levlin <[email protected]>
katrite
pushed a commit
that referenced
this pull request
Oct 15, 2020
* CSCFAIRMETA-647: [FIX] bug with almost simultaneous requests - LightFileserializer made modifications to class variable so when two requests came almost at the same time the latter was using modified version of the variable. Fixed with deepcopy - Changed app to use local Elasticsearch with tests since it is now working * CSCFAIRMETA-710: [FIX] _mapping endpoint and ES in testcases - Correctly call elasticsearch when request comes to _mapping endpoint - Tests can be run against local elasticsearch which reduces the population time - Follow naming convention in refdata loader with non-internal functions * CSCFAIRMETA-710: [FIX] remove unnecessary variable * CSCFAIRADM-337: [ADD] Update domain references (#631) - These mostly concern test data, but should be updated still * CSCFAIRMETA-704 [FIX] merge-draft-does-not-save-changes - In merge_draft take preservation_state from draft cr * CSCFAIRMETA-704-merge-draft-does-not-save-changes - Change metax-demo to metax.demo * CSCFAIRMETA-716: [FIX] create-draft-internal-error-when-draft-already-exists - Add a check for next_draft * CSCFAIRMETA-712-Issues-with-emails -Add migration to change email and organization name * CSCFAIRMETA-712-Issues-with-emails - Add check whether metadata_owner_org or metadata_provider_org exists * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Add ?keys=datasets|files and ?keysonly=bool - Remove parameter ?detailed as it is the same as ?keys=files * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Add test for parameter ?keysonly * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Add support for leaving argument ?detailed * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset Add ?keysonly return input list except standalone files or datasets without files * CSCFAIRMETA-636-return-if-files-are-part-of-some-dataset - Refactor sql's - Fix parameters 'request' and 'preferred_identifier' * CSCFAIRMETA-762-New-links-for-SYKE-datasets - Save old notation into own field - Replace notation with new guid - Add datasets folder into migrations - Replace syke url for harvester Co-authored-by: Tommi Pulli <[email protected]> Co-authored-by: Tommi Pulli <[email protected]> Co-authored-by: Mattias Levlin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.