Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix System.Dynamic.DynamicObject based Serialization via Newtonsoft.Json #37

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Fix System.Dynamic.DynamicObject based Serialization via Newtonsoft.Json #37

merged 4 commits into from
Sep 25, 2024

Conversation

kMutagene
Copy link
Member

@kMutagene kMutagene commented Sep 24, 2024 •
edited
Loading

This PR

  • Updates the project to .NET 8 because why is it still 6
  • fixes Newtonsoft.Json Serialization:
    • when not transpiling, inherit System.Dynamic.DynamicObject
    • add necessary overrides, especially _.GetDynamicMemberNames()
  • adds basic serialization tests

@kMutagene kMutagene requested a review from HLWeil September 24, 2024 07:26
@kMutagene kMutagene linked an issue Sep 24, 2024 that may be closed by this pull request
Fix Newtonsoft.Json serialization #33
Closed
@kMutagene kMutagene mentioned this pull request Sep 24, 2024
Closed
@kMutagene
Copy link
Member Author

this good @HLWeil ?

@kMutagene
remove newtonsoft dependency from core library (it serializes out of …
fb334d3 
…the box), add pending System.Text.Json tests
@kMutagene kMutagene merged commit 3c9b1bf into main Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HLWeil HLWeil HLWeil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Newtonsoft.Json serialization
2 participants
@kMutagene @HLWeil