Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynObj rework and various tests #32

Merged
merged 5 commits into from
Sep 19, 2024
Merged

DynObj rework and various tests #32

merged 5 commits into from
Sep 19, 2024

Conversation

kMutagene
Copy link
Member

@kMutagene kMutagene commented Sep 10, 2024 •
edited
Loading

This PR will

  • Rework the DynObj API (parameter order, some new functions, XML docs)
  • Add various tests
    • All instance methods of DynamicObj()
    • All static methods from DynObj

@kMutagene kMutagene linked an issue Sep 10, 2024 that may be closed by this pull request
Improve DynObj module, add tests #30
Closed
@kMutagene kMutagene marked this pull request as ready for review September 17, 2024 06:50
@kMutagene
Copy link
Member Author

Ready for review @HLWeil

HLWeil
HLWeil requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@HLWeil HLWeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!
But I don't agree with the tests rename. I think DynamicObj and DynObj would both better represent the functionality and the files of interest.

src/DynamicObj/DynObj.fs Show resolved Hide resolved
tests/DynamicObject.Tests/DynObjStaticMethods.fs Show resolved Hide resolved
@kMutagene kMutagene merged commit f928164 into main Sep 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HLWeil HLWeil HLWeil requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve DynObj module, add tests
2 participants
@kMutagene @HLWeil