Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Items Bug Fixed #47

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Required Items Bug Fixed #47

merged 5 commits into from
Mar 7, 2024

Conversation

akanshyabhat
Copy link
Contributor

Required Items Bug Fixed

♻️ Current situation & Problem

There were two buttons for Required Items that were showing up for each appointment block.

⚙️ Release Notes

  • Removed the code for the second button

📚 Documentation

N/A

✅ Testing

Will update after testing completes

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 31.20%. Comparing base (501b616) to head (93080da).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   31.30%   31.20%   -0.09%     
==========================================
  Files          54       54              
  Lines        2937     2930       -7     
==========================================
- Hits          919      914       -5     
+ Misses       2018     2016       -2     
Files Coverage Δ
PICS/Appointment/AppointmentBlock.swift 64.41% <ø> (-0.74%) ⬇️
PICS/Appointment/AppointmentInformation.swift 18.02% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 501b616...93080da. Read the comment docs.

Copy link
Contributor

@YurenSUN YurenSUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akanshyabhat akanshyabhat merged commit 380ea88 into main Mar 7, 2024
7 checks passed
@akanshyabhat akanshyabhat deleted the required_items branch March 7, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants