Fix capturing references to stack variables #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Comment on lines
+177
to
+149
| is_suppress_events_enabled_ = _other.is_suppress_events_enabled_; | ||
|
|
There was a problem hiding this comment.
are this changes also part of the fix? as they were not mentioned on Aram's comment #730
There was a problem hiding this comment.
They were discussed in the vsomeip meeting at the same time he was discussing the other issues.
|
Hi @kheaactua
|
kheaactua
force-pushed
the
fix_captured_references_main
branch
from
aaf6b6e to
daa82a5
Compare
Got it! Thanks!
|
These were reported in COVESA#730 Co-authored-by: Aram Khzarjyan <[email protected]> Co-authored-by: Sambit Patnaik <[email protected]>
duartenfonseca
force-pushed
the
fix_captured_references_main
branch
from
daa82a5 to
9702844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture errors discovered by Aram's team. I don't have Aram's (@akhzarj ?) contact info so I can't add a
Co-authored-bytag in the commit