(WIP) Docker compose quality of life improvements and/or cleanup before 0.1.0 release #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates in VISS support: 1) UPSTREAM VISS PROJECT MOVE AND RENAME The WAII data server project we use for VISS support has migrated from W3C github infrastructure to COVESA github. At the same time it was renamed from WAII to VISSR. Update the submodule to use the new name and location. 2) UPDATE TO CURRENT UPSTREAM HEAD FOR APACHE IOTDB SUPPORT Most importantly the changes to VISSR developed as part of this project to add Apache IoTDB support as a data store backend have now all been merged upstream. In summary these are in three areas: support for IoTDB to get/set VSS data, document IoTDB in the VISSR documentation site and provide runtime configuration of the connection parameters to IoTDB. Rebasing on the current VISSR HEAD allows the playground to point to the upstream rather than a fork carrying the changes. Support was successfully sanity tested doing get/set operations using Apache IoTDB and the VISSR html client. Signed-off-by: Stephen Lawrence <[email protected]>
The VISSR submodule has been updated to point at the upstream head Commit. As a result integrate changes in the upstream VISSR docker compose docker-compose-rl.yml into the VISSR services of the playground compose. Successfully sanity tested with get/set operation using the VISSR html client. Signed-off-by: Stephen Lawrence <[email protected]>
The top-level version property in a compose file is now considered obsolete by the docker project. If its include current docker compose versions output a warning such as: WARN[0000] <path>/docker-compose-waii-iotdb.yml: `version` is obsolete For details see: docker/compose#11628 jasonacox/Powerwall-Dashboard#453 To quiet the warning remove the version property. Signed-off-by: Stephen Lawrence <[email protected]>
Signed-off-by: Stephen Lawrence <[email protected]>
1) Set Apache IoTDB service to restart always. 2) Make vissv2server service depend on IoTDB to mitigate race conditions where the VISS server is started before IoTDB is started. Signed-off-by: Stephen Lawrence <[email protected]>
Simplify the top level name to just 'cdsp' to represent the base configuration. Previously it was cdsp-waii-iotdb. Signed-off-by: Stephen Lawrence <[email protected]>
Rename docker-compose-waii-iotdb.yml to docker-compose-cdsp.yml Signed-off-by: Stephen Lawrence <[email protected]>
3 tasks
Update the docker compose README.md to bring it into alignment with recent changes to the playground compose file. Such as: 1. Upstream VISS data server project name change from WAII to VISSR 2. Compile file rename Also take the opportunity to do some general text cleanup and add a build tip related to corporate security systems. Signed-off-by: Stephen Lawrence <[email protected]>
Add build note that VISSR requires you to manually generate the file vss_vissv2.binary. Add tip showing how to start the playground with IoTDB only if you are blocked by VISSR build issues. Signed-off-by: Stephen Lawrence <[email protected]>
Remove the distracting trailing $ prompt from the CLI examples. Signed-off-by: Stephen Lawrence <[email protected]>
|
Close pull request in favor of opening new one with rebases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP collection of commits for docker compose polishing before 0.1.0 release for the AMM