Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4614] Fix discussions content & typo #2924

Merged

Conversation

ClayBenson94
Copy link
Collaborator

EASI-4614

Description

Updates a typo and some content changes to accurately reflect current functionality!

How to test this change

  • Just make sure the content looks correct, and that no snapshot tests fail!

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@ClayBenson94 ClayBenson94 requested review from a team as code owners December 13, 2024 13:51
@ClayBenson94 ClayBenson94 requested review from mynar7, aterstriep and downeyn-cms and removed request for a team December 13, 2024 13:51
@ClayBenson94 ClayBenson94 changed the base branch from main to feature/EASI-4614_grb_discussions December 13, 2024 13:51
Copy link
Contributor

@mynar7 mynar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arpprproved

@ClayBenson94 ClayBenson94 merged commit 8e68dc9 into feature/EASI-4614_grb_discussions Dec 13, 2024
7 checks passed
@ClayBenson94 ClayBenson94 deleted the EASI-4614/fix_discussions_typo branch December 13, 2024 13:52
Copy link

EKS Ingress URLs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants