Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] Add support for EKS ignore label #2919

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

ClayBenson94
Copy link
Collaborator

@ClayBenson94 ClayBenson94 commented Dec 12, 2024

NOREF

Description

  • Adds support for eks_ignore label. When present, EKS deploys on that PR will not execute.

How to test this change

  • I tested this change on this PR by creating it with the eks_ignore label, and we can see the job failure here
  • When re-running, the same event information is used, so it will also fail (you'll need to push a new commit to trigger a deployment)

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

Copy link
Contributor

@Jdwoodson Jdwoodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! LGTM

@ClayBenson94 ClayBenson94 merged commit 9bd4755 into main Dec 12, 2024
14 of 15 checks passed
@ClayBenson94 ClayBenson94 deleted the NOREF/eks_pause_label branch December 12, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants