Skip to content

Commit

Permalink
Update namespace prefix in workflows and adjust PR teardown script
Browse files Browse the repository at this point in the history
  • Loading branch information
Jdwoodson committed Dec 10, 2024
1 parent 9f3c1ca commit 99f8145
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ jobs:
needs: [Build_Application_Images,Build_easi-frontend_image]
secrets: inherit
with:
namespace: easi-pr-${{ github.event.number }}
namespace: easi-${{ github.event.number }}
13 changes: 12 additions & 1 deletion .github/workflows/deploy_to_eks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ on:
permissions:
id-token: write
contents: read
pull-requests: write

env:
GIT_HASH: ${{ github.sha }}
Expand Down Expand Up @@ -46,11 +47,21 @@ jobs:
echo "- [EASi](http://${EASI_INGRESS})" >> $GITHUB_STEP_SUMMARY
echo "- [Mailcatcher](http://${EMAIL_INGRESS})" >> $GITHUB_STEP_SUMMARY
echo "- [Minio Console](http://${MINIO_CONSOLE_INGRESS})" >> $GITHUB_STEP_SUMMARY
#TODO: Remove this step
- name: Set outputs
id: set-outputs
run: |
echo "${{ github.event }}"
echo "${{ github.event_name }}"
echo "${{ github.event.pull_request }}"
- name: Comment on PR
if: github.event_name == 'pull_request'
uses: thollander/actions-comment-pull-request@v3
with:
comment-tag: ingress-urls
message: |
Hello world ! :wave:
This is a comment on ${{ github.event.number }}
reactions: eyes, rocket
2 changes: 1 addition & 1 deletion .github/workflows/pr_teardown_env_on_close.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ jobs:
- name: Teardown branch environment
# The "easi-pr-" prefix needs to match the prefix in build_and_test.yml so that we delete the correct namespace
run: |
kubectl delete namespace "easi-pr-$PR_NUMBER" --force --ignore-not-found
kubectl delete namespace "easi-$PR_NUMBER" --force --ignore-not-found

0 comments on commit 99f8145

Please sign in to comment.