Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write request and response handling functions for message parser payloads #1291

Closed
bamader opened this issue Feb 8, 2024 · 1 comment · Fixed by #1324
Closed

Write request and response handling functions for message parser payloads #1291

bamader opened this issue Feb 8, 2024 · 1 comment · Fixed by #1324
Assignees
Labels

Comments

@bamader
Copy link
Collaborator

bamader commented Feb 8, 2024

No description provided.

@bamader bamader added the viper label Feb 8, 2024
@bamader
Copy link
Collaborator Author

bamader commented Feb 8, 2024

As part of the orchestration overhaul, each of the services connected to the orchestration container (validation, convert to fhir, ingestion, message parsing, save to DB) needs a function that not only composes appropriate input to send to the API, but unpacks response output for processing in the next service. Right now, we have a relatively uncontrolled data flow of kwargs, globals, and other hard to grok code, so the scope of this ticket is to right new, modular, decomposed I/O methods responsible for working with the message parser service.

Acceptance Criteria:

  • A function build_message_parser_request is written which takes as input the general model of the orchestration service and formulates it as a dictionary whose K-V pairs match the model input of the message parser service (which is dependent on the endpoint being hit)
  • A function unpack_message_parser_response is written which takes as input the response object of the message parser service, checks its status code (returning an error if the code isn't 200), and returns data/information in general form so that the next service call, whatever it might be, can atomically use the information without coupling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants