Skip to content

Commit

Permalink
Merge pull request #36 from yipeeio/update-ui-dockerfile
Browse files Browse the repository at this point in the history
Update ui dockerfile
  • Loading branch information
Dann Church authored Dec 17, 2018
2 parents 32c04da + c879b3a commit cf36a39
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 17 deletions.
2 changes: 1 addition & 1 deletion api/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:8.12.0-alpine
FROM node:8.14.0-alpine
WORKDIR /usr/src/app
# Uncomment kubectl installation if you want api support
# for "experimental" features
Expand Down
2 changes: 1 addition & 1 deletion api/api_build.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash

CVT_NAME=api-build-converter
API_IMG=node:8.12.0-alpine
API_IMG=node:8.14.0-alpine
# sleep to make sure converter starts before we try to use it...
API_CMD="npm install && sleep 5 && npm test"

Expand Down
17 changes: 2 additions & 15 deletions ui/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,19 +1,8 @@
FROM nginx:1.15.5-alpine as builder
ARG HTML_DEST=/usr/html
ARG DEFAULT_CFG=default.conf
FROM node:8.14.0-alpine as builder
WORKDIR /app
COPY . /app
RUN rm -rf /usr/html/index.html && \
apk add --update --no-cache chromium \
git \
g++ \
make \
openssh-client \
python \
npm && \
npm install npm@latest -g && \
RUN apk add --update --no-cache chromium && \
npm install && \
npm install @angular/[email protected] --save-dev -g && \
export CHROME_BIN=/usr/bin/chromium-browser && \
npm run test-prod

Expand All @@ -26,6 +15,4 @@ RUN rm -rf /usr/html/index.html
COPY ./${DEFAULT_CFG} /etc/nginx/conf.d/
COPY ./run /etc/sysctl.d/
COPY --from=builder /app/dist ${HTML_DEST}
# mkdir -p -m 777 ${HTML_DEST}
# COPY --from=builder /app/dist ${HTML_DEST}
EXPOSE 80
6 changes: 6 additions & 0 deletions ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{
"name": "yipee",
"version": "2.0.229",
"peerDependencies": {
"@angular/core": "~7.0.2"
},
"license": "MIT",
"scripts": {
"ng": "ng",
Expand Down

0 comments on commit cf36a39

Please sign in to comment.