-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local-time: switch from time
to jiff
#31
Conversation
Let me know if you want me to remove the |
Thanks a lot for contributing! I can't wait to merge and use it from within A quick test showed that it didn't actually show the local time though, but I am looking into it to see what the issue could be.
The time displayed is UTC, I should be +2h. AnswerI was looking at RustLog output, which naturally doesn't use local times (or needs configuration to do). |
You can also drop this outdated part of the README: 🙂 Line 36 in 10800f3
|
This swaps out `time` in favor of `jiff` for getting and formatting the local time. Note that this does add the `%Z` to the format string, which will write out time zone abbreviations like `EDT` along with the local datetime itself. The `time` crate doesn't support this, but jiff's tzdb integration let's it do it.
@Mrmaxmeier Done! @Byron Yeah, I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, a new release is out and I will make |
This swaps out
time
in favor ofjiff
for getting and formatting thelocal time.
Note that this does add the
%Z
to the format string, which will writeout time zone abbreviations like
EDT
along with the local datetimeitself. The
time
crate doesn't support this, but jiff's tzdbintegration let's it do it.