Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Output TRA files on PV gen #97

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

NicerNewerCar
Copy link
Contributor

@NicerNewerCar NicerNewerCar commented May 14, 2024

Note this will require that #96 be integrated before this can be fully tested

Closes #93

Of Note: Slicer 2 Autoscoper Transform
https://github.com/NicerNewerCar/SlicerAutoscoperM/blob/8564243035cd3e4c3fdfacc1e693a44341bf60da/AutoscoperM/AutoscoperMLib/IO.py#L294-L298

image

@NicerNewerCar NicerNewerCar requested review from jcfr and amymmorton May 14, 2024 16:39
Copy link
Contributor

@amymmorton amymmorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome
image

@NicerNewerCar NicerNewerCar force-pushed the tra-generation branch 2 times, most recently from e4aa280 to 9691d12 Compare May 16, 2024 16:13
@NicerNewerCar NicerNewerCar marked this pull request as ready for review May 16, 2024 16:13
@NicerNewerCar NicerNewerCar requested a review from amymmorton May 16, 2024 16:13
Copy link
Contributor

@amymmorton amymmorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicerNewerCar
Copy link
Contributor Author

@NicerNewerCar what was modified from the previously approved pr 2 days ago?

Some logic related to how the Origin2Dicom transform is applied during the AutomaticVRGGen pipeline.

AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperMLib/IO.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperMLib/IO.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperMLib/IO.py Show resolved Hide resolved
Copy link

@sjh26 sjh26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@NicerNewerCar NicerNewerCar merged commit 7a2dd0f into BrownBiomechanics:main Jun 3, 2024
2 checks passed
@NicerNewerCar NicerNewerCar deleted the tra-generation branch June 3, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply .tfm of partial volumes on launch
4 participants