Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscoper Read the Docs #117

Merged
merged 33 commits into from
Jun 14, 2023
Merged

Conversation

NicerNewerCar
Copy link
Contributor

@NicerNewerCar NicerNewerCar commented Apr 10, 2023

Pull request for setting up an RTD page for Autoscoper.

For future reference, see this page in the RTD documentation for setting up webhooks.

Documentation generated for this PR

Once this is merged into main PR #11 in the autoscoperm.slicer.org repo should be merged in.

Closes #127

TODO

  • Tutorial on filters -> from Tutorial suggestions #127
  • Add reference to IO info in tutorial -> from Tutorial suggestions #127
  • Update Autoscoper description -> from Amy
  • Add Click to enlarge for images -> from Amy Expanded content width to 100%
  • Fix issue with RTD not building class reference of PyAutoscoper

@NicerNewerCar

This comment was marked as resolved.

@NicerNewerCar NicerNewerCar mentioned this pull request Apr 10, 2023
@NicerNewerCar NicerNewerCar force-pushed the read-the-docs branch 2 times, most recently from d6ba22e to e27673c Compare April 10, 2023 19:35
Documentation/conf.py Outdated Show resolved Hide resolved
Documentation/conf.py Show resolved Hide resolved
Documentation/conf.py Outdated Show resolved Hide resolved
Documentation/conf.py Outdated Show resolved Hide resolved
Documentation/conf.py Outdated Show resolved Hide resolved
Documentation/conf.py Outdated Show resolved Hide resolved
Documentation/conf.py Show resolved Hide resolved
Documentation/conf.py Outdated Show resolved Hide resolved
Documentation/requirements.txt Outdated Show resolved Hide resolved
Documentation/socket-control-libraries/pyautoscoper.md Outdated Show resolved Hide resolved
@NicerNewerCar NicerNewerCar force-pushed the read-the-docs branch 2 times, most recently from dddc69e to 8348af0 Compare April 10, 2023 19:48
@jcfr

This comment was marked as resolved.

@NicerNewerCar NicerNewerCar force-pushed the read-the-docs branch 2 times, most recently from e48b85d to c808927 Compare April 27, 2023 20:48
@NicerNewerCar

This comment was marked as resolved.

@NicerNewerCar NicerNewerCar force-pushed the read-the-docs branch 3 times, most recently from e2a7146 to cb7d457 Compare May 16, 2023 14:54
@NicerNewerCar

This comment was marked as resolved.

@NicerNewerCar NicerNewerCar marked this pull request as ready for review May 16, 2023 17:03
@NicerNewerCar NicerNewerCar requested a review from jcfr May 16, 2023 17:04
@NicerNewerCar NicerNewerCar force-pushed the read-the-docs branch 4 times, most recently from ca97d98 to fbba0c7 Compare May 22, 2023 18:13
Copy link
Contributor

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, consider adding an empty line after each headers.

Documentation/developer-guide/contributing.md Outdated Show resolved Hide resolved
Documentation/index.md Outdated Show resolved Hide resolved
Documentation/index.md Outdated Show resolved Hide resolved
Documentation/conf.py Show resolved Hide resolved
Documentation/developer-guide/building-autoscoper.md Outdated Show resolved Hide resolved
@jcfr
Copy link
Contributor

jcfr commented May 25, 2023

Considering also adding a dependency to https://sphinx-design.readthedocs.io

@NicerNewerCar NicerNewerCar force-pushed the read-the-docs branch 3 times, most recently from d99f9ac to e152cd8 Compare May 25, 2023 16:19
jcfr added 9 commits June 14, 2023 08:56
This commit fixes the following warnings:

/path/to/Autoscoper/CONTRIBUTING.md:19: WARNING: Non-consecutive header level increase; H2 to H4 [myst.header]
/path/to/Autoscoper/CONTRIBUTING.md:38: WARNING: Non-consecutive header level increase; H2 to H4 [myst.header]
/path/to/Autoscoper/CONTRIBUTING.md:47: WARNING: Non-consecutive header level increase; H2 to H4 [myst.header]
/path/to/Autoscoper/CONTRIBUTING.md:100: WARNING: Non-consecutive header level increase; H2 to H4 [myst.header]
/path/to/Autoscoper/CONTRIBUTING.md:116: WARNING: Non-consecutive header level increase; H2 to H4 [myst.header]
This commit fixes warnings like the following:

/path/to/Autoscoper/Documentation/tutorials/filters.md:5:
WARNING: local id not found in doc 'user-interface': 'rendering-options' [myst.xref_missing]

It also updates the `myst_heading_anchors` from `3` to `4` to fix the
following warning:

/path/to/Autoscoper/Documentation/tutorials/sample-data.md:71:
WARNING: local id not found in doc 'user-interface': 'importexport-tracking-options' [myst.xref_missing]
Since warning have effectively been fixed, this commit removes the
invalid option "supress_warnings". It should have been "suppress_warnings"

See https://myst-parser.readthedocs.io/en/latest/configuration.html#build-warnings
@NicerNewerCar NicerNewerCar force-pushed the read-the-docs branch 4 times, most recently from 1648099 to 24aa19a Compare June 14, 2023 19:40
jcfr added 7 commits June 14, 2023 17:53
The UI component is now consistent with the remaining of the application

$ ack "\>OK"
autoscoper/src/ui/ui-files/NewTrialDialog.ui
27:      <string>OK</string>

autoscoper/src/ui/ui-files/TrackingOptionsDialog.ui
65:        <string>OK</string>

autoscoper/src/ui/ui-files/ImportExportTrackingOptionsDialog.ui
418:      <string>OK</string>

autoscoper/src/ui/ui-files/OpenCLPlatformSelectDialog.ui
45:        <string>OK</string>
Also update references to button name from "Ok" to "OK"
- use warning/seealso/tip admonitions
- add additional empty line
Copy link
Contributor

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NicerNewerCar for putting together the documentation and thanks @amymmorton for the review 💯 🙏

🚀

@jcfr jcfr merged commit 3503ea4 into BrownBiomechanics:main Jun 14, 2023
@NicerNewerCar NicerNewerCar deleted the read-the-docs branch June 15, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial suggestions
3 participants