Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for node 16 #135

Merged

Conversation

Dulajdeshan
Copy link
Contributor

@Dulajdeshan Dulajdeshan commented Feb 11, 2024

fixes #111

  • Changes were structured by the logical commits/MRs: one logical change - one commit/MR.
  • MR pipeline is green.
  • Tests are added/updated (if relevant).
  • Change are fully described in the MR description.
  • Impact Analysis were provided.
  • The related MRs are linked to the current (if relevant).
  • Reviewers are assigned.
  • All the required labels are added. Read more.

Glossary

  • ✅ - covered with tests
  • 💥 - impacted
  • CodeReview process - documentation/CODE_REVIEW.md

Detailed description of changes

  • Removed node 16 from package.json node engine support range
  • Added node 18 as minimum support node version
  • Updated CI/CD workflows with node 18
  • Upgraded few dependencies to latest versions
    • @strapi/design-system (1.6.3 -> 1.14.1)
    • @strapi/helper-plugin (4.12.5 -> 4.20.0)
    • @strapi/icons (1.11.0 -> 1.14.1)
    • prop-types (15.7.2 -> 15.8.1)

Impact Analysis

The context of changes (optionally)

Drop node 16 support

A brief description of the essence of your changes.

  • Drop node 16 support
  • Upgraded few dependencies to latest versions
    • @strapi/design-system (1.6.3 -> 1.14.1)
    • @strapi/helper-plugin (4.12.5 -> 4.20.0)
    • @strapi/icons (1.11.0 -> 1.14.1)
    • prop-types (15.7.2 -> 15.8.1)

How the system components behaved before your changes. ⬅️

  • Worked fine

How the system components behave after your changes. ➡️

  • Working fine

A description of the impact of your changes on the other parts of the system.

  • N/A

An assessment of the impact of your changes on the other parts of the system. 🔄

  • N/A

@BorysShulyak
Copy link
Owner

@Dulajdeshan Great work!

@BorysShulyak BorysShulyak merged commit 92a4cc9 into BorysShulyak:main Feb 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] Drop node@16 support
2 participants