Change FetchContent_Populate to FetchContent_MakeAvailable #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://cmake.org/cmake/help/latest/module/FetchContent.html#command:fetchcontent_populate, FetchContent_MakeAvailable ensures the named dependencies have been populated, either by an earlier call, or by populating them itself. This makes possible to get rid of the conditional.
|
TobiasDuswald
approved these changes
Aug 26, 2024
|
Thank you very much @imorlxs ! |
imorlxs
added a commit
that referenced
this pull request
Oct 8, 2024
See deprecation warning documented in #386.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #386, since FetchContent_Populate is deprecated we need to get rid of it. This PR makes this possible replacing it with the function
FetchContent_MakeAvailable