Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewind rack.input before reading from it #94

Merged
merged 1 commit into from
Jan 22, 2013

Conversation

virusman
Copy link
Contributor

If there is a middleware before better_errors, it may read from env['rack.input'] and leave it in eof state, thus causing better_errors to get a JSON parse error on an empty string.
This rewinds rack.input before reading from it, may fix #93, #84.

haileys pushed a commit that referenced this pull request Jan 22, 2013
Rewind rack.input before reading from it
@haileys haileys merged commit 5db3b8e into BetterErrors:master Jan 22, 2013
@m4n m4n mentioned this pull request Jan 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work with rails mountable engine
2 participants