Upgrade to replicon 0.16 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR, besides the one thing everything still works well so I will merge it when that's fixed 👍 The predicted event system is indeed not needed (It was a leftover from a previous implementation of prediction). You can remove it if you want or else I'll do it after! |
xentripetal
force-pushed
the
replicon-0.16.0
branch
2 times, most recently
from
8c495fe to
a3e6dae
Compare
|
Thanks! I'm not really sure what's up with the So just got rid of that and went with using serde directly instead. Also removed the unused system. |
xentripetal
force-pushed
the
replicon-0.16.0
branch
from
a3e6dae to
d41ef22
Compare
- use bevy minor version to permit consumer upgrades - Get rid of private bevy access and use serde directly - Remove unused system
xentripetal
force-pushed
the
replicon-0.16.0
branch
from
d41ef22 to
687af95
Compare
Bendzae
approved these changes
Nov 3, 2023
src/lib.rs
Outdated
| @@ -6,7 +6,7 @@ use std::io::Cursor; | |||
| use bevy::ecs::world::EntityMut; | |||
| use bevy::prelude::*; | |||
| use bevy::ptr::Ptr; | |||
| use bevy::reflect::erased_serde::__private::serde::{Deserialize, Serialize}; | |||
| use bevy::reflect::erased_serde::private::serde::{Deserialize, Serialize}; | |||
There was a problem hiding this comment.
No Idea why I was using this import path in the first place but let's use use serde::{Deserialize, Serialize};;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note, cargo complains that lib.rs::predicted_event_system() is unused. Is this intentional or should it be registered with add_client_predicted_event?)