Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update-PodeWebText doesn't work properly with code/blocks #233

Closed
Badgerati opened this issue Dec 2, 2021 · 0 comments · Fixed by #236
Closed

Update-PodeWebText doesn't work properly with code/blocks #233

Badgerati opened this issue Dec 2, 2021 · 0 comments · Fixed by #236
Assignees
@Badgerati
Labels
bug 🐛 Something isn't working
Milestone
0.7.0

Comments

@Badgerati
Copy link
Owner

The issue seems to be that .find(...) in jQuery returns and object even when there are no elements found, so ?? never returns the original text element.
@Badgerati Badgerati added the bug 🐛 Something isn't working label Dec 2, 2021
@Badgerati Badgerati added this to the 0.7.0 milestone Dec 2, 2021
@Badgerati Badgerati self-assigned this Dec 2, 2021
Badgerati added a commit that referenced this issue Dec 2, 2021
@Badgerati
#233: fix update-text to work with code blocks
ca26d03
@Badgerati Badgerati mentioned this issue Dec 2, 2021
Merged
@Badgerati Badgerati mentioned this issue Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Badgerati Badgerati

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Fix update-text to work with code blocks Badgerati/Pode.Web
1 participant
@Badgerati