Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Sign In" button needs a spinner! #209

Closed
Badgerati opened this issue Nov 16, 2021 · 0 comments · Fixed by #219
Closed

The "Sign In" button needs a spinner! #209

Badgerati opened this issue Nov 16, 2021 · 0 comments · Fixed by #219
Assignees
@Badgerati
Labels
bug 🐛 Something isn't working
Milestone
0.7.0

Comments

@Badgerati
Copy link
Owner

Pretty much as the title says! 😃

Without the spinner, if sign-in happens to take a little while then it looks like the page is doing nothing. The spinner should appear when "Sign In" is clicked - like other buttons, the spinner should be within the button.
@Badgerati Badgerati added the bug 🐛 Something isn't working label Nov 16, 2021
@Badgerati Badgerati self-assigned this Nov 21, 2021
@Badgerati Badgerati added this to the 0.7.0 milestone Nov 21, 2021
Badgerati added a commit that referenced this issue Nov 21, 2021
@Badgerati
#209: fix for login submit missing spinner
488f3f7
@Badgerati Badgerati mentioned this issue Nov 21, 2021
Merged
@Badgerati Badgerati mentioned this issue Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Badgerati Badgerati

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Fix for login submit missing spinner Badgerati/Pode.Web
1 participant
@Badgerati