Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AddCityStateRow() #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lautit
Copy link

@lautit lautit commented Oct 3, 2018

As it is being replaced with the RnF implementation of the same. Maybe execution order? To investigate

As it is being replaced with the RnF implementation of the same. Maybe execution order? To investigate
@lautit
Copy link
Author

lautit commented Oct 3, 2018

Solves #355

@jglassmaker
Copy link

This also needs AddInfluenceRow renamed as well. Otherwise only 1 shows in the city state influence list.

@oseparovic
Copy link

Any update on this? The bug still exists and makes the mod unusable for the time being.

Have only seen this after installing Rise and Fall, base game was never affected in my experience

@lilgallon
Copy link

lilgallon commented Dec 26, 2018

I got it working by refactoring AddInfluenceRow to AddInfluenceRowMod as well (thanks to the @jglassmaker comment).

@oseparovic
Copy link

For me I noticed it only affected single player games. If you play multiplayer (even if you're the only non-AI) it doesn't have the same problem with City States (Win 7, Steam install)

@Ionaru
Copy link

Ionaru commented Feb 11, 2019

@Azurency please have a look at this PR.

Copy link
Collaborator

@sparrow8332 sparrow8332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works Just fine and formatting is ok

Will wait for @Azurency to Merge

@ihendriks
Copy link
Contributor

ihendriks commented Feb 27, 2019

Shouldn't the solution be to fix it in the overriding file from expansion1 (not from CQUI, but from the DLC). Not sure though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants