-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor AddCityStateRow() #369
base: master
Are you sure you want to change the base?
Conversation
As it is being replaced with the RnF implementation of the same. Maybe execution order? To investigate
Solves #355 |
This also needs |
Any update on this? The bug still exists and makes the mod unusable for the time being. Have only seen this after installing Rise and Fall, base game was never affected in my experience |
I got it working by refactoring |
For me I noticed it only affected single player games. If you play multiplayer (even if you're the only non-AI) it doesn't have the same problem with City States (Win 7, Steam install) |
@Azurency please have a look at this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works Just fine and formatting is ok
Will wait for @Azurency to Merge
Shouldn't the solution be to fix it in the overriding file from |
As it is being replaced with the RnF implementation of the same. Maybe execution order? To investigate