Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Storage Supplier (again) #1729

Merged
merged 5 commits into from
May 10, 2023
Merged

Consolidate Storage Supplier (again) #1729

merged 5 commits into from
May 10, 2023

Conversation

rpdome
Copy link
Member

@rpdome rpdome commented May 2, 2023

@rpdome rpdome added the No-Changelog This request does not update the changelog label May 2, 2023
@rpdome rpdome marked this pull request as ready for review May 2, 2023 20:29
@rpdome rpdome requested a review from a team as a code owner May 2, 2023 20:29
@iamgusain
Copy link
Collaborator

Can you add changelog. As this must contains the corresponding breaking change in common.

@rpdome rpdome merged commit 5827334 into dev May 10, 2023
@rpdome rpdome deleted the rapong/refactorStorageSupplierAgain branch May 10, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissaahn melissaahn melissaahn approved these changes

@fadidurah fadidurah fadidurah approved these changes

Assignees
No one assigned
Labels
No-Changelog This request does not update the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpdome @iamgusain @fadidurah @melissaahn