Remove dependency from common's storagehelper #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpdome
commented
Apr 18, 2023
rpdome
commented
Apr 18, 2023
melissaahn
approved these changes
Apr 18, 2023
p3dr0rv
reviewed
Apr 18, 2023
p3dr0rv
reviewed
Apr 18, 2023
p3dr0rv
approved these changes
Apr 18, 2023
rpdome
added a commit
to AzureAD/microsoft-authentication-library-common-for-android
that referenced
this pull request
Apr 18, 2023
One ADAL test is failing because it's passing a null in a nonnull parameter. Looking into the method, it seems that the parameter should indeed be nullable. --- I also made another method public for AzureAD/azure-activedirectory-library-for-android#1725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ADAL use its own copy of StorageHelper.... so that we can kill common's storageHelper for good.
related: AzureAD/microsoft-authentication-library-common-for-android#2013