Update Feast to support 0.18.x and later #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to support 0.18.1
mssql patch to enable persist & metadata method
feast materialize fix
fix readme, add build folder to gitignore
Improve readme, add info to build feast-azure-provider
Merge with Azure main
Review readme, remove redundant dependencies
fix blob permission
samuel100
reviewed
Mar 6, 2022
| @@ -357,3 +357,8 @@ config.json | |||
|
|
|||
There was a problem hiding this comment.
What is this file used for?
There was a problem hiding this comment.
gitignore file and folder generated by recompiling feast-azure-provider
samuel100
reviewed
Mar 6, 2022
| ```bash | ||
| python setup.py install | ||
| ``` | ||
|
|
||
|
|
There was a problem hiding this comment.
Can you elaborate on what a custom version of the feast-azure-provider is?
There was a problem hiding this comment.
This is to let contributors build and install their own feast-azure-provider for testing. At the moment the docs does not mention how to build and install feast-azure-provider outside of pypi repository - https://pypi.org/project/feast-azure-provider/
cbtham
changed the title
Add support for feast 0.19.x
cbtham
changed the title
Update build command to whl instead of egg
Limit feast-azure-provider to 0.18.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Latest feast version tested working is 0.18.1