Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for FilterBlobs and fixing encoding issue #19742

Merged
merged 8 commits into from
Jan 6, 2023

Conversation

siminsavani-msft
Copy link
Contributor

@siminsavani-msft siminsavani-msft commented Jan 3, 2023

Fixes #17421

Golang's Encoding method returns '+' instead of '%20' for spaces, causing issues with encoding. The change is made in a transformative script.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jan 3, 2023
@vibhansa-msft vibhansa-msft added this to the azblob v1.0.0-beta milestone Jan 4, 2023
@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@souravgupta-msft
Copy link
Member

Please make sure to add an entry in the changelog.

@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@siminsavani-msft
Copy link
Contributor Author

/azp run go - azblob

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In FindBlobsByTags API it encode space character to + which result in error from Azure
6 participants