fix: "Countainer Apps should disable external network access" triggers when no ingress #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when no ingress **Problem** "Countainer Apps should disable external network access" policy erroneously triggers on container apps without ingress. This causes the policy to incorrectly flag non-http workloads, and other workloads without ingress, as non-compliant. **Solution** Only validate `configuration.ingress.external` value if `configuration.ingress` exists.
christianfosli
requested review from
robga,
cemheren,
gokmen-msft and
calecarter
as code owners
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
"Countainer Apps should disable external network access" policy erroneously triggers on container apps without ingress.
This causes the policy to incorrectly flag non-http workloads, and other workloads without ingress, as non-compliant.
Solution
Only validate
configuration.ingress.externalvalue ifconfiguration.ingressexists.