-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sync from noir #9483
Merged
Merged
feat: Sync from noir #9483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m, if any (noir-lang/noir#6371) feat: let LSP suggest traits in trait bounds (noir-lang/noir#6370) fix: LSP auto-import would import public item inside private module (noir-lang/noir#6366) fix: remove assumed parent traits (noir-lang/noir#6365) fix: slightly better formatting of empty blocks with comments (noir-lang/noir#6367) fix: Fix panic in comptime code (noir-lang/noir#6361) feat: let the LSP import code action insert into existing use statements (noir-lang/noir#6358) chore: minor tweaks to comptime doc (noir-lang/noir#6357) feat: LSP auto-import will try to add to existing use statements (noir-lang/noir#6354) fix: allow type aliases in let patterns (noir-lang/noir#6356) feat(test): Run test matrix on stdlib tests (noir-lang/noir#6352) fix(ssa): Do not mark an array from a parameter mutable (noir-lang/noir#6355) fix: always inline `derive_generators` (noir-lang/noir#6350) chore: add test to check that duplicate definitions generated from macros throws error (noir-lang/noir#6351)
* master: (62 commits) chore: dont show aws creds in docker fast (#9465) fix: make sure kind tests run every master commit (#9478) feat: simulate latency with network chaos (#9469) feat: fixed number of pub inputs for databus commitment propagation (#9336) chore(CI): remove end-to-end/Earthfile (#9364) chore!: use Brillig opcode when possible for less-than operations on fields (#9416) fix: remove unnecessary ivpk's from aztec-nr (#9460) feat: Sync from noir (#9425) chore!: split base rollup and remove public kernel proving (#9434) refactor: clean up note processor after changes due to address (#9401) feat(avm): merkle tree gadget (#9205) fix: docker fast (#9467) chore(avm:): Fix execution tests in proving mode (#9466) chore: remove unnecessary trait (#9437) fix: yarn build:fast (#9464) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: cleanup of janky encryption apis (#9390) ...
… references (noir-lang/noir#6375) fix: (LSP) check visibility of module that re-exports item, if any (noir-lang/noir#6371) feat: let LSP suggest traits in trait bounds (noir-lang/noir#6370) fix: LSP auto-import would import public item inside private module (noir-lang/noir#6366) fix: remove assumed parent traits (noir-lang/noir#6365) fix: slightly better formatting of empty blocks with comments (noir-lang/noir#6367) fix: Fix panic in comptime code (noir-lang/noir#6361) feat: let the LSP import code action insert into existing use statements (noir-lang/noir#6358) chore: minor tweaks to comptime doc (noir-lang/noir#6357) feat: LSP auto-import will try to add to existing use statements (noir-lang/noir#6354) fix: allow type aliases in let patterns (noir-lang/noir#6356) feat(test): Run test matrix on stdlib tests (noir-lang/noir#6352) fix(ssa): Do not mark an array from a parameter mutable (noir-lang/noir#6355) fix: always inline `derive_generators` (noir-lang/noir#6350) chore: add test to check that duplicate definitions generated from macros throws error (noir-lang/noir#6351)
…oir-lang/noir#6375) fix: (LSP) check visibility of module that re-exports item, if any (noir-lang/noir#6371) feat: let LSP suggest traits in trait bounds (noir-lang/noir#6370) fix: LSP auto-import would import public item inside private module (noir-lang/noir#6366) fix: remove assumed parent traits (noir-lang/noir#6365) fix: slightly better formatting of empty blocks with comments (noir-lang/noir#6367) fix: Fix panic in comptime code (noir-lang/noir#6361) feat: let the LSP import code action insert into existing use statements (noir-lang/noir#6358) chore: minor tweaks to comptime doc (noir-lang/noir#6357) feat: LSP auto-import will try to add to existing use statements (noir-lang/noir#6354) fix: allow type aliases in let patterns (noir-lang/noir#6356) feat(test): Run test matrix on stdlib tests (noir-lang/noir#6352) fix(ssa): Do not mark an array from a parameter mutable (noir-lang/noir#6355) fix: always inline `derive_generators` (noir-lang/noir#6350) chore: add test to check that duplicate definitions generated from macros throws error (noir-lang/noir#6351)
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
@jfecher fyi I've had to revert the change to how we handle references to arrays in this sync. |
TomAFrench
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: do not increment reference counts on arrays through references (noir-lang/noir#6375)
fix: (LSP) check visibility of module that re-exports item, if any (noir-lang/noir#6371)
feat: let LSP suggest traits in trait bounds (noir-lang/noir#6370)
fix: LSP auto-import would import public item inside private module (noir-lang/noir#6366)
fix: remove assumed parent traits (noir-lang/noir#6365)
fix: slightly better formatting of empty blocks with comments (noir-lang/noir#6367)
fix: Fix panic in comptime code (noir-lang/noir#6361)
feat: let the LSP import code action insert into existing use statements (noir-lang/noir#6358)
chore: minor tweaks to comptime doc (noir-lang/noir#6357)
feat: LSP auto-import will try to add to existing use statements (noir-lang/noir#6354)
fix: allow type aliases in let patterns (noir-lang/noir#6356)
feat(test): Run test matrix on stdlib tests (noir-lang/noir#6352)
fix(ssa): Do not mark an array from a parameter mutable (noir-lang/noir#6355)
fix: always inline
derive_generators
(noir-lang/noir#6350)chore: add test to check that duplicate definitions generated from macros throws error (noir-lang/noir#6351)
END_COMMIT_OVERRIDE