feat!: replace public key fetching API

[nventuro]

Closes #7953.

This was fairly straightforward since it turns out almost all key fetching locations requested the current keys and not historical ones. The only historical callsite is easy_private_voting, as expected.

Most of the callsites were simple replacements of the old API for the new one - in some of them it was clear that we were fetching multiple keys for the same account, and in those I added small edits so that'd we'd reuse the previously fetched keys.

With this, the token transfer gate count sits at 49k. Once we do #7954 we'll be able to reuse the npks we're computing in note creation, dropping ~10k further gates.

[AztecBot]

Docs Preview

Hey there! 👋 You can check your preview at https://66bf19a420254eedb452e5b1--aztec-docs-dev.netlify.app

[sklppy88]

Looks good 👍

[benesjan]

Nice

@nventuro I'll just merge this now to avoid conflicts with my other PRs today (plan on merging token and token with refunds).

It's broken! 🤣

[benesjan]

• feat!: replace public key fetching API #7996 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nventuro and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (FeeJuice:mint_public): 37.9 (-34%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,781	1,586 (+1%)	707	765 (+1%)	770 (+1%)
proof_construction_time_sha256_30_ms	11,905	3,185	1,411	1,447 (+1%)	1,466
proof_construction_time_sha256_100_ms	45,457	12,023 (-2%)	5,467	5,402	5,385
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	58.0 (-3%)	87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,533	421	204 (+1%)	229	270 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,658	1,518	676	735 (-4%)	754 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,684	92,448	177,560
l1_rollup_execution_gas	1,383,133	2,130,865	3,958,016
l2_block_processing_time_in_ms	250 (-4%)	451 (+3%)	797 (-2%)
l2_block_building_time_in_ms	9,204 (-1%)	18,055 (-1%)	35,814 (-1%)
l2_block_rollup_simulation_time_in_ms	9,204 (-1%)	18,055 (-1%)	35,814 (-1%)
l2_block_public_tx_process_time_in_ms	7,764 (-1%)	16,512 (-1%)	34,226 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,110 (+8%)	3,872 (+3%)
node_database_size_in_bytes	12,648,528	16,777,296 (+1%)
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	90.3 (-6%)	402 (-3%)	21,673	44,858	N/A
private-kernel-inner	164 (+1%)	718	72,309	45,005	N/A
private-kernel-reset-tiny	496 (-3%)	902	65,974	44,844	N/A
private-kernel-tail	206 (-1%)	167	50,728	52,256	N/A
base-parity	5.55 (-1%)	N/A	160	96.0	N/A
root-parity	33.2	N/A	69,084	96.0	N/A
base-rollup	2,840 (-1%)	N/A	187,817	664	N/A
root-rollup	38.6 (-1%)	N/A	54,525	716	N/A
public-kernel-setup	97.8 (-3%)	N/A	103,760	71,222	N/A
public-kernel-app-logic	103 (-1%)	N/A	103,599	71,222	N/A
public-kernel-tail	573 (-1%)	N/A	409,190	16,414	N/A
private-kernel-reset-small	490 (-3%)	N/A	66,085	45,629	N/A
private-kernel-tail-to-public	1,014 (-1%)	656 (-1%)	492,960	1,697	N/A
public-kernel-teardown	92.3 (-3%)	N/A	104,005	71,222	N/A
merge-rollup	19.1	N/A	35,742	664	N/A
undefined	N/A	N/A	N/A	N/A	65,305 (-1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	341 (-2%)
ContractInstanceDeployer:deploy	1,408	11,731	18.1 (-1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	421 (-2%)
FeeJuice:deploy	1,376	11,731	388
SchnorrAccount:constructor	1,312	11,731	105 (-2%)
SchnorrAccount:entrypoint	2,304	11,731	429 (-1%)
Token:privately_mint_private_note	1,280	11,731	143 (-1%)
FPC:fee_entrypoint_public	1,344	11,731	29.7 (+8%)
Token:transfer	1,312	11,731	271 (-7%)
Benchmarking:create_note	1,344	11,731	103 (+1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.6 (-1%)
Token:unshield	1,376	11,731	561
FPC:fee_entrypoint_private	1,376	11,731	750 (-3%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	52.7 (-2%)	8,139
FeeJuice:set_portal	10.7 (-16%)	2,362
Token:constructor	82.9 (-2%)	31,107
FPC:constructor	53.9	22,380
FeeJuice:mint_public	⚠️ 37.9 (-34%)	6,150
Token:mint_public	51.0 (+17%)	11,720
Token:assert_minter_and_mint	68.0	8,028
AuthRegistry:set_authorized	45.3 (-2%)	4,537
FPC:prepare_fee	237 (-1%)	8,812
Token:transfer_public	33.9 (+16%)	47,374
FPC:pay_refund	59.7 (+3%)	12,114
Benchmarking:increment_balance	964 (-1%)	7,450
Token:_increase_public_balance	39.4 (+2%)	8,960
FPC:pay_refund_with_shielded_rebate	67.4	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.161 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.17	3.84 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113	0.109 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.7 (+2%)	18.1 (+1%)	30.6 (-5%)	60.5 (+3%)	112 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.113 (+2%)	0.106 (+1%)	0.0998 (-4%)	0.104 (+3%)	0.101 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.5 (-1%)	25.8	43.3 (-3%)	83.4 (+2%)	161 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.110 (-1%)	0.104 (+1%)	0.105 (-3%)	0.103 (+2%)	0.101 (-3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |